netdev - Re: POLLPRI/poll() behavior change since 2.6.31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 07 Jan 2011 14:31:45 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Davide Libenzi <davidel@...ilserver.org>
Cc:	Leonardo Chiquitto <leonardo.lists@...il.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: POLLPRI/poll() behavior change since 2.6.31

Le jeudi 06 janvier 2011 à 14:40 -0800, Davide Libenzi a écrit :
> On Thu, 6 Jan 2011, Eric Dumazet wrote:
> 
> > Hmm, this is because 	sock_def_readable() uses :
> > 
> > wake_up_interruptible_sync_poll(&wq->wait, POLLIN | POLLRDNORM |
> > POLLRDBAND);
> > 
> > So POLLPRI bit is not signaled. 
> > 
> > I would just add POLLPRI flag in sock_def_readable()
> > 
> > (Alternatively, define a tcp_def_readable() function to pass POLLPRI
> > only if TCP_URG is set, but is it worth the pain for a seldom used
> > feature ?)
> 
> It would be kinda cleaner though, /me thinks.
> 

Yep, we'll do this in net-next-2.6 for 2.6.39 :)

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html