netdev - Re: [patch] Re: genetlink misinterprets NEW as GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110109.162533.241446494.davem@davemloft.net>
Date:	Sun, 09 Jan 2011 16:25:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	jengelh@...ozas.de, blp@...ira.com,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch] Re: genetlink misinterprets NEW as GET

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Fri, 07 Jan 2011 14:33:08 +0100

> On 07/01/11 14:15, Jan Engelhardt wrote:
>> netlink: test for all flags of the NLM_F_DUMP composite
>> 
>> Due to NLM_F_DUMP is composed of two bits, NLM_F_ROOT | NLM_F_MATCH,
>> when doing "if (x & NLM_F_DUMP)", it tests for _either_ of the bits
>> being set. Because NLM_F_MATCH's value overlaps with NLM_F_EXCL,
>> non-dump requests with NLM_F_EXCL set are mistaken as dump requests.
>> 
>> Substitute the condition to test for _all_ bits being set.
>> 
>> Signed-off-by: Jan Engelhardt <jengelh@...ozas.de>
> 
> Acked-by: Pablo Neira Ayuso <pablo@...filter.org>

Applied, and queued up for -stable, thanks guys!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html