netdev - Re: [PATCH net-next-2.6 v2 1/2] can: add driver for Softing card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110110134006.GC31011@pengutronix.de>
Date:	Mon, 10 Jan 2011 14:40:06 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Kurt Van Dijck <kurt.van.dijck@....be>
Cc:	Wolfgang Grandegger <wg@...ndegger.com>,
	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6 v2 1/2] can: add driver for Softing card


> > > +	if (type != 0xffff) {
> > > +		dev_alert(&card->pdev->dev, "firware starts with type 0x%04x\n",
> > 
> > Typo?
> > 
> ??

I think he means "fir[m]ware"

> > > +
> > > +int softing_default_output(struct net_device *netdev)
> > > +{
> > > +	struct softing_priv *priv = netdev_priv(netdev);
> > > +	struct softing *card = priv->card;
> > > +
> > > +	switch (priv->chip) {
> > > +	case 1000:
> > > +		if (card->pdat->generation < 2)
> > > +			return 0xfb;
> > > +		return 0xfa;

A ternary operator might look nicer here because of just a single return.

Best wishes,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)