[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110109.181336.91348184.davem@davemloft.net>
Date: Sun, 09 Jan 2011 18:13:36 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: error27@...il.com
Cc: remi.denis-courmont@...ia.com, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org, dan.j.rosenberg@...il.com
Subject: Re: [patch] phonet: some signedness bugs
From: David Miller <davem@...emloft.net>
Date: Sun, 09 Jan 2011 16:45:48 -0800 (PST)
> From: Dan Carpenter <error27@...il.com>
> Date: Fri, 7 Jan 2011 23:37:55 +0300
>
>> Dan Rosenberg pointed out that there were some signed comparison bugs
>> in the phonet protocol.
>>
>> http://marc.info/?l=full-disclosure&m=129424528425330&w=2
>>
>> If you have already have CAP_SYS_ADMIN then you could use the bugs to
>> get root, or someone could cause an oops by mistake.
>>
>> Signed-off-by: Dan Carpenter <error27@...il.com>
>
> Applied and queued up for -stable, thanks Dan.
Actually I'm reverting this.
You can't change the prototype of pn_socket_create() because if you do
then it doesn't match up with the prototype required by
net_proto_family->create().
You didn't see this warning in your build?
net/phonet/af_phonet.c:124:2: warning: initialization from incompatible pointer type
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists