netdev - Re: [PATCH] Cleanup include/net/tcp.h include-files and coding-style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110110075032.e38955ef.rdunlap@xenotime.net>
Date:	Mon, 10 Jan 2011 07:50:32 -0800
From:	Randy Dunlap <rdunlap@...otime.net>
To:	christoph.paasch@...ouvain.be
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Ben Hutchings <bhutchings@...arflare.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Cleanup include/net/tcp.h include-files and
 coding-style

On Mon, 10 Jan 2011 12:44:24 +0100 Christoph Paasch wrote:

> 
> On Monday, January 10, 2011 wrote Alexey Dobriyan:
> > >> linux/percpu_counter.h (needed for percpu_counter_sum_positive)
> > > 
> > > Yes.
> > 
> > Currently code compiles fine, so necessary headers are in place,
> > so simply adding new headers doesn't help anything.
> 
> I totally agree with you.
> However we need a consistent coding style.
> 
> Or we just include the minimum necessary headers (as originally proposed by 
> me).
> Or we include every header whose structs/functions are referenced.
> 
> In my opinion the current "mixed" state is not ok, because some includes are 
> there because there *are* references (even if these includes could be omitted, 
> e.g., linux/list.h).
> Other includes (like linux/percpu_counter.h) are not there, because they are 
> indirectly included by another header and thus the code compiles. Even if 
> there are references.
> And there are no rules/guidelines to identify the headers that should be 
> included and those that should not.

Documentation/SubmitChecklist, #1:

1: If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html