netdev - Re: [RFC] sched: CHOKe packet scheduler (v0.4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110111154806.6525e210@s6510>
Date:	Tue, 11 Jan 2011 15:48:06 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC] sched: CHOKe packet scheduler (v0.4)

On Tue, 11 Jan 2011 07:34:10 +0100
Eric Dumazet <eric.dumazet@...il.com> wrote:

> Le mardi 11 janvier 2011 à 07:18 +0100, Eric Dumazet a écrit :
> > Le lundi 10 janvier 2011 à 17:10 -0800, Stephen Hemminger a écrit :
> > > OK, put that in.
> > 
> > Thanks !
> > 
> > > > 
> > > > Here we missed :
> > > > 
> > > > 		q->tab = ntab;
> > > > 
> > 
> > We also need to change 
> > 
> > .peek       =   qdisc_peek_head,
> > 
> > to
> > 
> > .peek = choke_peek_head,
> > 
> > static struct sk_buff *choke_peek_head(struct Qdisc *sch)
> > {
> > 	struct choke_sched_data *q = qdisc_priv(sch);
> > 
> > 	return (q->head != q->tail) ? q->tab[q->head] : NULL;
> > }
> > 
> > 
> 
> 
> And to correctly work with CBQ (at least...), we need to update 
> sch->q.qlen = choke_len(q) - q->holes;
> in dequeue() and enqueue()
> 
> Here is the version I successfully tested, with 30000 packets in
> queue :)
> 
> qdisc choke 11: parent 1:11 limit 70000b min 10000b max 30000b ewma 1 Plog 16 Scell_log 11
>  Sent 62099201 bytes 112920 pkt (dropped 367712, overlimits 282668 requeues 0) 
>  rate 21344Kbit 4851pps backlog 39877589b 30001p requeues 0 
>   marked 0 early 282668 pdrop 0 other 0

Maybe we should take over one of the red counters for the probabilistic match drop.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html