netdev - Re: [PATCH 2/3] net/dummy: add device group parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110111121746.GC26417@cormyr>
Date:	Tue, 11 Jan 2011 14:17:46 +0200
From:	Vlad Dogaru <ddvlad@...edu.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, hadi@...erus.ca, opurdila@...acom.com
Subject: Re: [PATCH 2/3] net/dummy: add device group parameter

On Mon, Jan 10, 2011 at 01:37:48PM -0800, David Miller wrote:
> From: Vlad Dogaru <ddvlad@...edu.org>
> Date: Mon, 10 Jan 2011 13:38:43 +0200
> 
> > When inserting the dummy module, the user can specify the group of the
> > dummy devices. This avoids manually moving the newly created pseudo
> > devices to a different group.
> > 
> > Signed-off-by: Vlad Dogaru <ddvlad@...edu.org>
> 
> The amount of hacks people wish to add to the dummy driver is one step
> away from amazing.
> 
> Just use the standard APIs to add dummy devices to the group you want,
> instead of these ad-hoc device specific module parameters.

Sorry for attempting to bloat the dummy module. The intention was to be
able to add many dummy interfaces directly into a group without much
user-kernel communication.

However, I think that can be done by moving the existing (hopefully few)
interfaces to another group prior to adding the dummies to group 0 and
using that to manipulate them.

Vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html