lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jan 2011 23:25:41 +1000 From: Greg Ungerer <gerg@...pgear.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> CC: <baruch@...s.co.il>, <B32542@...escale.com>, <netdev@...r.kernel.org>, Sascha Hauer <s.hauer@...gutronix.de>, <jamie@...reable.org>, <w.sang@...gutronix.de>, <r64343@...escale.com>, <linux-arm-kernel@...ts.infradead.org>, <eric@...rea.com>, <bryan.wu@...onical.com>, <jamie@...ieiles.com>, <davem@...emloft.net>, Shawn Guo <shawn.guo@...escale.com>, <lw@...o-electronics.de> Subject: Re: [PATCH v4 05/10] net/fec: add dual fec support for mx28 Hi Uwe, On 11/01/11 23:07, Uwe Kleine-König wrote: > Hi Greg, > > On Tue, Jan 11, 2011 at 10:24:12PM +1000, Greg Ungerer wrote: >> On 11/01/11 20:27, Sascha Hauer wrote: >>> On Thu, Jan 06, 2011 at 03:13:13PM +0800, Shawn Guo wrote: >>> This option is used nowhere and should be removed. Certainly it does not >>> have the effect of enabling the second ethernet controller. >> >> It does for a ColdFire platform... >> >> grep -r CONFIG_FEC2 * >> >> arch/m68knommu/configs/m5275evb_defconfig:CONFIG_FEC2=y >> arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2 >> arch/m68knommu/platform/527x/config.c:#ifdef CONFIG_FEC2 > IMHO Sascha's comment[1] applies here, too. I am not arguing that it doesn't :-) Simply that removing that config option and doing nothing else would not be the right thing to do. Regards Greg > And someone might want to do what he suggested soon or the patch > removing CONFIG_FEC2[2] needs to be commented accordingly. > > Best regards > Uwe > > [1] http://thread.gmane.org/gmane.linux.network/182929/focus=183378 > [2] http://mid.gmane.org/1294747672-4433-1-git-send-email-shawn.guo@freescale.com > -- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: gerg@...pgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close, FAX: +61 7 3891 3630 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists