netdev - Re: [PATCH v2] sh: sh_eth: Add support ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110111074914.60915b2b@s6510>
Date:	Tue, 11 Jan 2011 07:49:14 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	nobuhiro.iwamatsu.yj@...esas.com
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	yoshihiro.shimoda.uh@...esas.com, bhutchings@...arflare.com
Subject: Re: [PATCH v2] sh: sh_eth: Add support ethtool

On Tue, 11 Jan 2011 20:58:29 +0900
nobuhiro.iwamatsu.yj@...esas.com wrote:

> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>
> 
> This commit supports following functions.
>  - get_drvinfo
>  - get_settings
>  - set_settings
>  - nway_reset
>  - get_msglevel
>  - set_msglevel
>  - get_link
>  - get_strings
>  - get_ethtool_stats
>  - get_sset_count
> 
> About other function, the device does not support.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@...esas.com>

I agree with Eric, the statistics interface is not necessary if all
the statistics are only the standard values.  The netdev stats are available
through several other interfaces already.

It would be nice to allow configuring the ring sizes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html