netdev - RE: [E1000-devel] [e100] Page allocation failure warning(?) in 2.6.36.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.WNT.2.00.1101120958080.5816@JBRANDEB-DESK2.amr.corp.intel.com>
Date:	Wed, 12 Jan 2011 10:05:11 -0800 (Pacific Standard Time)
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	David Miller <davem@...emloft.net>,
	Eric Dumazet <eric.dumazet@...il.com>
cc:	Chris Rankin <rankincj@...oo.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"Dave, Tushar N" <tushar.n.dave@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: RE: [E1000-devel] [e100] Page allocation failure warning(?) in
 2.6.36.3

Hi Eric, thanks for doing this work!

On Wed, 12 Jan 2011, Eric Dumazet wrote:
> Apparently e100 driver uses GFP_ATOMIC allocations in setup phase, and
> your machine doesnt have enough memory.

This part looks great.
 
> I would try following patch, allowing the use of GFP_KERNEL at init
> time, to let vm games play.
> 
> Thanks
> 
> [PATCH] e100: use GFP_KERNEL allocations at device init stage
> 
> In lowmem conditions, e100 driver can fail its initialization, because
> of GFP_ATOMIC abuse.
> 
> Switch to GFP_KERNEL were applicable.
> 
> Add __GFP_NOWARN flag to GFP_ATOMIC allocations, since driver can cope
> with failed allocations (if setup succeeded)
> 
> Reported-by: Chris Rankin <rankincj@...oo.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>

> -		if (unlikely(e100_rx_alloc_skb(nic, rx)))
> +		if (unlikely(e100_rx_alloc_skb(nic, rx,
> +					       GFP_ATOMIC | __GFP_NOWARN)))

First, I don't think the following comment should hold up this patch.

As a policy question when I asked about using __GFP_NOWARN before in other 
Intel ethernet drivers the consensus seemed to be that the warning 
messages were useful.  All our drivers correctly handle runtime memory 
failures, but none of them are currently using __GFP_NOWARN.

Can I submit patches to change our other drivers to __GFP_NOWARN?  I think 
it will make for quite a few less reports of non-issues to the list.  All 
our drivers that I would be patching already have ethtool counters that 
count failed allocations.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html