netdev - Re: [PATCH] tcp: remove duplicate th = tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim3qQX2NhqZ99BF00WnviRi898aw7XE7BcJFfHH@mail.gmail.com>
Date:	Thu, 13 Jan 2011 10:54:14 -0500
From:	Jesse Gross <jesse@...ira.com>
To:	Christoph Paasch <christoph.paasch@...ouvain.be>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: remove duplicate th = tcp_hdr(skb)

On Thu, Jan 13, 2011 at 10:41 AM, Christoph Paasch
<christoph.paasch@...ouvain.be> wrote:
> th is already set some lines before to be th = tcp_hdr(skb).
>
> Signed-off-by: Christoph Paasch <christoph.paasch@...ouvain.be>
> ---
>  net/ipv4/tcp_ipv4.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 856f684..7fe29c6 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -1644,7 +1644,6 @@ int tcp_v4_rcv(struct sk_buff *skb)
>        if (!skb_csum_unnecessary(skb) && tcp_v4_checksum_init(skb))
>                goto bad_packet;
>
> -       th = tcp_hdr(skb);

It needs to be reloaded because pskb_may_pull() may reallocate the buffer.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html