netdev - Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110113.122856.112848917.davem@davemloft.net>
Date:	Thu, 13 Jan 2011 12:28:56 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	lucian.grijincu@...il.com
Cc:	netdev@...r.kernel.org, kuznet@....inr.ac.ru, pekkas@...core.fi,
	jmorris@...ei.org, yoshfuji@...ux-ipv6.org, kaber@...sh.net,
	opurdila@...acom.com, ddvlad@...edu.org
Subject: Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF_* from 0

From: Lucian Adrian Grijincu <lucian.grijincu@...il.com>
Date: Thu, 13 Jan 2011 14:23:41 +0200

> On Thu, Jan 13, 2011 at 12:02 PM, Thomas Graf <tgraf@...radead.org> wrote:
>> On Thu, Jan 13, 2011 at 09:50:14AM +0200, Lucian Adrian Grijincu wrote:
>>> Yes it works, but there does not seem to be a good reason why to
>>> complicate things like this (again the sentinel nature of zero is not
>>> used in any place here).
>>
>> I have no objects to changing this at all but we don't gain much either.
> 
> 
> Should I post a new patch in which IFLA_INET_CONF cfgid values start
> from 0 also or must the ABI for libnl be kept as-is (counting from 1)?

I think the conclusion is that we won't apply your change, sorry.

There is almost zero upside, and one known downside in that we have
to deal with this user visible breakage somehow.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html