netdev - Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110112.184734.38051229.davem@davemloft.net>
Date:	Wed, 12 Jan 2011 18:47:34 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	lucian.grijincu@...il.com
Cc:	netdev@...r.kernel.org, tgraf@...radead.org, kuznet@....inr.ac.ru,
	pekkas@...core.fi, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, opurdila@...acom.com, ddvlad@...edu.org
Subject: Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF_* from 0

From: Lucian Adrian Grijincu <lucian.grijincu@...il.com>
Date: Wed, 12 Jan 2011 12:19:10 +0200

> The IPV4_DEVCONF_* enums are never exposed to the userspace and it
> would make code simpler to remove all the useless (-1) adjustments.

Starting values like this at "1" is usually done on purpose.

It allows "0" to be illegal or mean "none", and thus easily trapping
cases where the value fails to be initialized properly.  In this way
the illegal sentinel "0" doesn't take up any space either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html