netdev - Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110113100224.GB30432@canuck.infradead.org>
Date:	Thu, 13 Jan 2011 05:02:24 -0500
From:	Thomas Graf <tgraf@...radead.org>
To:	Lucian Adrian Grijincu <lucian.grijincu@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	kuznet@....inr.ac.ru, pekkas@...core.fi, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, opurdila@...acom.com,
	ddvlad@...edu.org
Subject: Re: [PATCH] ipv4: devconf: start IPV4_DEVCONF_* from 0

On Thu, Jan 13, 2011 at 09:50:14AM +0200, Lucian Adrian Grijincu wrote:
> Yes it works, but there does not seem to be a good reason why to
> complicate things like this (again the sentinel nature of zero is not
> used in any place here).

The reason I didn't change anything was the same as Dave's reply, I
thought it must have been done on purpose. It probably was but I can't
spot any reason now either.

Also, IPv6 is doing just fine with using '0' as its first devconf id.

I have no objects to changing this at all but we don't gain much either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html