netdev - Re: [PATCH 2/2] ks8695net: Use default implementation of ethtool_ops::get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110113.215109.247138667.davem@davemloft.net>
Date:	Thu, 13 Jan 2011 21:51:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	figo1802@...il.com, zealcook@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ks8695net: Use default implementation of
 ethtool_ops::get_link

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 13 Jan 2011 17:52:51 +0000

> This is completely untested as I don't have an ARM build environment.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
 ...
> -/**
>   *	ks8695_wan_get_pause - Retrieve network pause/flow-control
> advertising
>   *	@ndev: The device to retrieve settings from
>   *	@param: The structure to fill out with the information

Line-wrap damage from your mail client.

> @@ -1058,7 +1044,7 @@ static const struct ethtool_ops
> ks8695_wan_ethtool_ops = {
>  	.get_settings	= ks8695_wan_get_settings,

Same here.

I fixed this up and applied your patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html