[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTimyZQ1BEJ=tPK4LrYWhQaGd+xhYUsVEENibEVoU@mail.gmail.com>
Date: Sat, 15 Jan 2011 15:03:31 +0100
From: Sjur Brændeland <sjurbren@...il.com>
To: Dan Carpenter <error27@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [patch] caif: checking the wrong variable
> In the original code we check if (servl == NULL) twice. The first time
> should print the message that cfmuxl_remove_uplayer() failed and set
> "ret" correctly, but instead it just returns success. The second check
> should be checking the value of "ret" instead of "servl".
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
Thank you for spotting and correcting this.
Looks good to me (reviewed only)
Acked-by: Sjur Braendeland <sjur.brandeland@...ricsson.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists