netdev - Re: [patch] 9p: fix min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi=vdKX9ruvrdiPgnr59WWrGaP0roFyBvqWW3VSU@mail.gmail.com>
Date:	Sun, 16 Jan 2011 10:33:16 -0600
From:	Eric Van Hensbergen <ericvh@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	David Miller <davem@...emloft.net>, sripathik@...ibm.com,
	jvrao@...ux.vnet.ibm.com, aneesh.kumar@...ux.vnet.ibm.com,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	mohan@...ibm.com
Subject: Re: [patch] 9p: fix min_t() casting

The patch has already made it upstream via the v9fs pull.  I'll pull
in your fix Dan and request a second pull by Linus.
Thanks for catching this.

      -eric


On Sun, Jan 16, 2011 at 5:45 AM, Dan Carpenter <error27@...il.com> wrote:
> On Sat, Jan 15, 2011 at 08:52:08PM -0800, David Miller wrote:
>> From: Dan Carpenter <error27@...il.com>
>> Date: Sat, 15 Jan 2011 23:35:39 +0300
>>
>> > The intent here was to cap the length to USHRT_MAX, but what the
>> > code actually does is it just casts the return from strlen() to
>> > unsigned short and truncates the significant bits away.
>> >
>> > Signed-off-by: Dan Carpenter <error27@...il.com>
>>
>> If you want me to apply this, it doesn't apply cleanly to net-2.6
>> at all.
>
> Sorry.  I screwed up.
>
> This was on top of a patch from M. Mohan Kumar <mohan@...ibm.com>
> that hasn't hit net-2.6 yet.  Mohan wasn't included on the CC
> list because get_maintainer.pl changed and I didn't notice and
> I wasn't careful.
>
> Eric, could Mohan just fix his patch before it gets merged or is it
> better to send these as two patches?
>
> regards,
> dan carpenter
>
> Ps:  Mohon the patch is here:
> http://marc.info/?l=linux-netdev&m=129512381528034&w=2
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html