netdev - Re: [PATCH] net: fix can_checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=sJGFPNkzG9sDDjiREsRXVj8U_rWNr6sWvhX-e@mail.gmail.com>
Date:	Wed, 19 Jan 2011 05:33:25 -0800
From:	Jesse Gross <jesse@...ira.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Hans de Bruin <jmdebruin@...net.nl>
Subject: Re: [PATCH] net: fix can_checksum_protocol() arguments swap

On Wed, Jan 19, 2011 at 2:51 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> commit 0363466866d901fbc (net offloading: Convert checksums to use
> centrally computed features.) mistakenly swapped can_checksum_protocol()
> arguments.
>
> This broke IPv6 on bnx2 for instance, on NIC without TCPv6 checksum
> offloads.
>
> Reported-by: Hans de Bruin <jmdebruin@...net.nl>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Jesse Gross <jesse@...ira.com>
> ---
> I cant believe I spent so much time on this bug.

Thanks Eric, I was staring at this code and I can't believe that I
didn't see it.

Acked-by: Jesse Gross <jesse@...ira.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html