[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110120.233144.233395234.davem@davemloft.net>
Date: Thu, 20 Jan 2011 23:31:44 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: shemminger@...tta.com
Cc: eric.dumazet@...il.com, netdev@...r.kernel.org, kaber@...sh.net,
hadi@...erus.ca, jarkao2@...il.com
Subject: Re: [PATCH] net_sched: accurate bytes/packets stats/rates
From: Stephen Hemminger <shemminger@...tta.com>
Date: Fri, 14 Jan 2011 11:03:42 -0800
> From Eric Dumazet <eric.dumazet@...il.com>
>
> In commit 44b8288308ac9d (net_sched: pfifo_head_drop problem), we fixed
> a problem with pfifo_head drops that incorrectly decreased
> sch->bstats.bytes and sch->bstats.packets
>
> Several qdiscs (CHOKe, SFQ, pfifo_head, ...) are able to drop a
> previously enqueued packet, and bstats cannot be changed, so
> bstats/rates are not accurate (over estimated)
>
> This patch changes the qdisc_bstats updates to be done at dequeue() time
> instead of enqueue() time. bstats counters no longer account for dropped
> frames, and rates are more correct, since enqueue() bursts dont have
> effect on dequeue() rate.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Acked-by: Stephen Hemminger <shemminger@...tta.com>
Applied to net-2.6, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists