netdev - Re: [PATCH] e1000: add support for Marvell Alaska M88E1118R PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201101211727.57971.ffainelli@freebox.fr>
Date:	Fri, 21 Jan 2011 17:27:57 +0100
From:	Florian Fainelli <ffainelli@...ebox.fr>
To:	Dirk Brandewie <dirk.j.brandewie@...el.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] e1000: add support for Marvell Alaska M88E1118R PHY

Hello Dirk, Jeff,

On Thursday 20 January 2011 19:49:19 Dirk Brandewie wrote:
> On Wed, 2011-01-19 at 22:51 -0800, Jeff Kirsher wrote:
> > On Wed, Jan 19, 2011 at 01:09, Florian Fainelli <ffainelli@...ebox.fr> 
wrote:
> > > From: Florian Fainelli <ffainelli@...ebox.fr>
> > > 
> > > This patch adds support for Marvell Alask M88E188R PHY chips. Support
> > > for other M88* PHYs is already there, so there is nothing more to add
> > > than its PHY id.
> > > 
> > > Signed-off-by: Florian Fainelli <ffainelli@...ebox.fr>
> > > CC: Dirk Brandewie <dirk.j.brandewie@...el.com>
> > > CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > > ---
> > 
> > The patch itself looks fine.  I am concerned about validation.
> > 
> > Dirk - is there a chance that the ce4100 will use this PHY?  If so,
> > can you cover the validation?
> 
> Florian is working on a CE4100 based platform.  It looks like they used
> a different PHY from the Flacon Falls reference platform. I can't
> directly test this patch since I don't have their hardware.  I will be
> testing .38-rc1 next week on falcon falls.

Indeed, we use this PHY on our hardware.

> 
> I think the best we can do without the hardware is to compare the data
> sheet for the new PHY with the PHYs already supported and make sure they
> are compatible.  If the datasheets match up for the features the driver
> is using this seems pretty low risk IMHO.

As far as I could check, all M88E111* should behave the same for the setup 
done in e1000.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html