netdev - Re: [PATCH net-next-2.6] net_sched: TCQ_F_CAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110121.162733.123411406.davem@davemloft.net>
Date:	Fri, 21 Jan 2011 16:27:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, kaber@...sh.net, hawk@...u.dk,
	jarkao2@...il.com, hadi@...erus.ca
Subject: Re: [PATCH net-next-2.6] net_sched: TCQ_F_CAN_BYPASS generalization

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 21 Jan 2011 12:04:41 +0100

> Now qdisc stab is handled before TCQ_F_CAN_BYPASS test in
> __dev_xmit_skb(), we can generalize TCQ_F_CAN_BYPASS to other qdiscs
> than pfifo_fast : pfifo, bfifo, pfifo_head_drop and sfq
> 
> SFQ is special because it can have external classifiers, and in these
> cases, we cannot bypass queue discipline (packet could be dropped by
> classifier) without admin asking it, or further changes.
> 
> Its worth doing this, especially for SFQ, avoiding dirtying memory in
> case no packets are already waiting in queue.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks.

> I am not sure RED can use bypass too, feel free to comment on this ;)

The only thing that RED would seem to care about would be the
queue size average calculation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html