netdev - Re: [PATCH v2 02/16] net: change netdev->features to u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1295778913.17333.28.camel@edumazet-laptop>
Date:	Sun, 23 Jan 2011 11:35:13 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	netdev@...r.kernel.org, Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH v2 02/16] net: change netdev->features to u32

Le samedi 22 janvier 2011 à 23:14 +0100, Michał Mirosław a écrit :
> Quoting Ben Hutchings: we presumably won't be defining features that
> can only be enabled on 64-bit architectures.
> 
> Occurences found by `grep -r` on net/, drivers/net, include/
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---

...

>  	/* Unset features, set them as we chew on the arg. */
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 371fa88..c73d63d 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -894,7 +894,7 @@ struct net_device {
>  	struct list_head	unreg_list;
>  
>  	/* Net device features */
> -	unsigned long		features;
> +	u32			features;
>  #define NETIF_F_SG		1	/* Scatter/gather IO. */
>  #define NETIF_F_IP_CSUM		2	/* Can checksum TCP/UDP over IPv4. */
>  #define NETIF_F_NO_CSUM		4	/* Does not require checksum. F.e. loopack. */
> @@ -1150,7 +1150,7 @@ struct net_device {
>  	const struct rtnl_link_ops *rtnl_link_ops;
>  
>  	/* VLAN feature mask */
> -	unsigned long vlan_features;
> +	u32 vlan_features;
>  
>  	/* for setting kernel sock attribute on TCP connection setup */


Could you move "vlan_features" right after "features", so that no holes
are there on 64bit arches ?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html