netdev - Re: [stable] [RFC] ipv6: don't flush routes when setting loopback down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Jan 2011 11:21:29 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Willy Tarreau <w@....eu>, jbohac@...e.cz, yoshfuji@...ux-ipv6.org,
	netdev@...r.kernel.org, stable@...nel.org,
	stephen.hemminger@...tta.com, brian.haley@...com,
	lorenzo@...gle.com, David Miller <davem@...emloft.net>,
	maheshkelkar@...il.com
Subject: Re: [stable] [RFC] ipv6: don't flush routes when setting loopback down

Stephen Hemminger <shemminger@...tta.com> writes:

> I think this fixes the issue with disable_ipv6

Somehow I doubt deleting the ipv6 state, and removing the per device
disable_ipv6 flag is going to be backwards compatible.

echo 0 > /proc/sys/net/ipv6/conf/disable_ipv6

Won't work.

What ever other good properties calling NETDEV_UNREGISTER for ipv6
devices may have.

Eric

> --- a/net/ipv6/addrconf.c	2011-01-23 20:30:25.897243002 +1100
> +++ b/net/ipv6/addrconf.c	2011-01-23 20:30:41.161243002 +1100
> @@ -4197,7 +4197,7 @@ static void dev_disable_change(struct in
>  		return;
>  
>  	if (idev->cnf.disable_ipv6)
> -		addrconf_notify(NULL, NETDEV_DOWN, idev->dev);
> +		addrconf_notify(NULL, NETDEV_UNREGISTER, idev->dev);
>  	else
>  		addrconf_notify(NULL, NETDEV_UP, idev->dev);
>  }
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html