netdev - Re: 2.6.38-rc1: arp triggers RTNL assertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110124.131402.226784705.davem@davemloft.net>
Date:	Mon, 24 Jan 2011 13:14:02 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jamie@...ible.transient.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: 2.6.38-rc1: arp triggers RTNL assertion

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 24 Jan 2011 22:11:38 +0100

> Le vendredi 21 janvier 2011 à 13:06 -0800, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Fri, 21 Jan 2011 19:52:56 +0100
>> 
>> > Here is how I fixed this, thanks again Jamie !
>> > 
>> > [PATCH] net: neighbour: pneigh_lookup() doesnt need RTNL
>> 
>> Eric, I don't think we can do this.
>> 
>> Fundamentally, any time a user operation changes the configuration
>> of the networking, we must hold the RTNL.
>> 
>> Eliding the RTNL for lookups is fine, but for things that change
>> state it is not.
>> 
>> I therefore think you'll need to rework the arp_ioctl() portions
>> of the commit that introduced this regression.
>> 
> 
> Here is a second try of the fix, thanks !
> 
> Note : Tested with CONFIG_PROVE_RCU=y
> 
> [PATCH] net: arp_ioctl() must hold RTNL

Thanks Eric, this one looks a lot better.  I'll apply this later
tonight.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html