netdev - Re: [PATCH v2 14/16] Intel net drivers: convert to ndo_fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Jan 2011 23:06:32 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
Cc:	netdev@...r.kernel.org, Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH v2 14/16] Intel net drivers: convert to ndo_fix_features

2011/1/22 Michał Mirosław <mirq-linux@...e.qmqm.pl>:
> Private rx_csum flags are now duplicate of netdev->features & NETIF_F_RXCSUM.
> Removing this needs deeper surgery.
>
> Since ixgbevf doesn't change hardware state on RX csum enable/disable
> its reset is avoided.
>
> Things noticed:
>  - e1000, e1000e and ixgb have RX csum disabled by default
>  - HW VLAN acceleration probably can be toggled, but it's left as is
>  - the resets on RX csum offload change can probably be avoided
>  - there is A LOT of copy-and-pasted code here
>
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
>  drivers/net/e1000/e1000_ethtool.c  |   69 ------------------------------------
>  drivers/net/e1000/e1000_main.c     |   30 +++++++++++++--
>  drivers/net/e1000e/ethtool.c       |   62 --------------------------------
>  drivers/net/e1000e/netdev.c        |   30 +++++++++++++--
>  drivers/net/igb/igb_ethtool.c      |   67 ----------------------------------
>  drivers/net/igb/igb_main.c         |   33 +++++++++++++----
>  drivers/net/igbvf/ethtool.c        |   57 -----------------------------
>  drivers/net/igbvf/netdev.c         |   25 ++++++++++---
>  drivers/net/ixgb/ixgb.h            |    2 +
>  drivers/net/ixgb/ixgb_ethtool.c    |   59 +------------------------------
>  drivers/net/ixgb/ixgb_main.c       |   31 ++++++++++++++--
>  drivers/net/ixgbe/ixgbe_ethtool.c  |   65 ---------------------------------
>  drivers/net/ixgbe/ixgbe_main.c     |   31 +++++++++++-----
>  drivers/net/ixgbevf/ethtool.c      |   46 ------------------------
>  drivers/net/ixgbevf/ixgbevf_main.c |   26 +++++++++++---
>  15 files changed, 172 insertions(+), 461 deletions(-)
>

I have applied this patch for review and testing to my tree

I have also applied the 1-13 patches just for testing purposes, so
that we can adequately test the changes to the Intel Wired drivers

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html