| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110124.155144.35028895.davem@davemloft.net> Date: Mon, 24 Jan 2011 15:51:44 -0800 (PST) From: David Miller <davem@...emloft.net> To: mirq-linux@...e.qmqm.pl Cc: netdev@...r.kernel.org, bhutchings@...arflare.com Subject: Re: [PATCH v2 04/16] net: Introduce new feature setting ops From: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl> Date: Sat, 22 Jan 2011 23:14:13 +0100 (CET) > This introduces a new framework to handle device features setting. > It consists of: > - new fields in struct net_device: > + hw_features - features that hw/driver supports toggling > + wanted_features - features that user wants enabled, when possible > - new netdev_ops: > + feat = ndo_fix_features(dev, feat) - API checking constraints for > enabling features or their combinations > + ndo_set_features(dev) - API updating hardware state to match > changed dev->features > - new ethtool commands: > + ETHTOOL_GFEATURES/ETHTOOL_SFEATURES: get/set dev->wanted_features > and trigger device reconfiguration if resulting dev->features > changed > + ETHTOOL_GSTRINGS(ETH_SS_FEATURES): get feature bits names (meaning) > > Signed-off-by: Michaİİ Mirosİİaw <mirq-linux@...e.qmqm.pl> Ok, I'll stop applying patches right before this one as I'd like to see at least some feedback from Ben wrt. the ethtool bits. FWIW I like these changes (a lot). :-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists