netdev - Re: [PATCH] ipv6: Revert 'administrative down' address handling changes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110125.124908.112599966.davem@davemloft.net>
Date:	Tue, 25 Jan 2011 12:49:08 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, shemminger@...tta.com, brian.haley@...com,
	lorenzo@...gle.com, herbert@...dor.hengli.com.au
Subject: Re: [PATCH] ipv6: Revert 'administrative down' address handling
 changes.

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Tue, 25 Jan 2011 10:55:31 -0800

> ebiederm@...ssion.com (Eric W. Biederman) writes:
> 
>> David Miller <davem@...emloft.net> writes:
>>
>>> From: David Miller <davem@...emloft.net>
>>> Date: Sun, 23 Jan 2011 23:41:01 -0800 (PST)
>>>
>>>> Eric B. and co., please do some testing to make sure all of your
>>>> disable_ipv6 cases are functioning properly with this applied.
>>>
>>> Ping?
>>
>> In progress.  I had to make a small change to your patch to get it
>> to apply against 2.6.37.  neigh_ifdown has not been removed from the
>> beginning of addrconf_ifdown there.  The piece that was failing for
>> me is not failing now so, so far so good.
>>
>> It was reported that in 2.6.37 there was a new regression that
>> 1connecting to ::1 when ipv6 was disabled would not fail immediately but
>> would have to wait a while.  With your patch applied I am not seeing
>> that behavior either.
>>
>> Tomorrow I should know if I see any weird side effects with your patch,
>> after my regression tests for everything else have finished running.
> 
> I have to admit I am seeing weird side effects.  A test that was
> mysteriously failing because it could not create a vlan on top of a tap
> device has started working again ;)
> 
> So this change is looking really good for me.

Thanks for the testing feedback, that's looking good enough for me,
I'll start pushing this fix around.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html