netdev - Re: [PATCH net-next-2.6] pktgen: speedup fragmented skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110125.132626.39178379.davem@davemloft.net>
Date:	Tue, 25 Jan 2011 13:26:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] pktgen: speedup fragmented skbs

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 25 Jan 2011 18:13:55 +0100

> We spend lot of time clearing pages in pktgen.
> (Or not clearing them on ipv6 and leaking kernel memory)
> 
> Since we dont modify them, we can use one zeroed page, and get
> references on it. This page can use NUMA affinity as well.
> 
> Define pktgen_finalize_skb() helper, used both in ipv4 and ipv6
> 
> Results using skbs with one frag :
> 
> Before patch :
> 
> Result: OK: 608980458(c608978520+d1938) nsec, 1000000000
> (100byte,1frags)
>   1642088pps 1313Mb/sec (1313670400bps) errors: 0
> 
> After patch :
> 
> Result: OK: 345285014(c345283891+d1123) nsec, 1000000000
> (100byte,1frags)
>   2896158pps 2316Mb/sec (2316926400bps) errors: 0
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, although I changed "->page = 0;" to "->page = NULL;"

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html