netdev - Re: [PATCH net-2.6] bnx2: Eliminate AER error messages on systems not supporting it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110126.142822.115949432.davem@davemloft.net>
Date:	Wed, 26 Jan 2011 14:28:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	leitao@...ux.vnet.ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] bnx2: Eliminate AER error messages on systems
 not supporting it

From: David Miller <davem@...emloft.net>
Date: Wed, 26 Jan 2011 14:26:35 -0800 (PST)

> From: "Michael Chan" <mchan@...adcom.com>
> Date: Wed, 26 Jan 2011 00:14:51 -0800
> 
>> On PPC for example, AER is not supported and we see unnecessary AER
>> error message without this patch:
>> 
>> bnx2 0003:01:00.1: pci_cleanup_aer_uncorrect_error_status failed 0xfffffffb
>> 
>> Reported-by: Breno Leitao <leitao@...ux.vnet.ibm.com>
>> Signed-off-by: Michael Chan <mchan@...adcom.com>
> 
> Applied.

Please check for warnings in your build, I ammended the following fix
into this commit:

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index 62c6079..0ba59d5 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -8540,7 +8540,7 @@ static pci_ers_result_t bnx2_io_slot_reset(struct pci_dev *pdev)
 	}
 	rtnl_unlock();
 
-	if (!bp->flags & BNX2_FLAG_AER_ENABLED)
+	if (!(bp->flags & BNX2_FLAG_AER_ENABLED))
 		return result;
 
 	err = pci_cleanup_aer_uncorrect_error_status(pdev);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html