netdev - RE: [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6D8AC2E@saturn3.aculab.com>
Date:	Fri, 28 Jan 2011 09:10:46 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	unlisted-recipients:; (no To-header on input)
Cc:	<netdev@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>
Subject: RE: [PATCH v2] gianfar: Fall back to software tcp/udp checksum on oldercontrollers

 
> +		if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12)
> +			     && ((unsigned long)fcb % 0x20) > 0x18)) {

You need to check the generated code, but I think you need:

    if (unlikely(gfar_has_errata(priv, GFAR_ERRATA_12))
	     && unlikely(((unsigned long)fcb % 0x20) > 0x18))

ie unlikely() around both the primitive comparisons.

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html