netdev - RE: [net-2.6 v2 5/7] ixgbe: DDP last buffer size work around

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C5E6457CD7911469A07260381288C28CBE83195@orsmsx502.amr.corp.intel.com>
Date:	Fri, 28 Jan 2011 13:36:15 -0800
From:	"Hanania, Amir" <amir.hanania@...el.com>
To:	David Miller <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"bphilips@...ell.com" <bphilips@...ell.com>
Subject: RE: [net-2.6 v2 5/7] ixgbe: DDP last buffer size work around

David,

Sorry I missed your mail from last night.

You are right, it should be bufflen, which is 4096 and not PAGE_SIZE.

I will fix that and resubmit.
-Amir


-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Friday, January 28, 2011 11:51 AM
To: Kirsher, Jeffrey T
Cc: Hanania, Amir; netdev@...r.kernel.org; gospo@...hat.com; bphilips@...ell.com
Subject: Re: [net-2.6 v2 5/7] ixgbe: DDP last buffer size work around

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 28 Jan 2011 04:29:01 -0800

> From: Amir Hanania <amir.hanania@...el.com>
> 
> We found a hardware erratum on 82599 hardware that can lead to buffer
> overwriting if the last buffer in FCoE DDP is exactly PAGE_SIZE.
> If this is the case, we will make sure that there is no HW access to
> this buffer.
> 
> Please see the 82599 Specification Update for more information.
> 
> Signed-off-by: Amir Hanania <amir.hanania@...el.com>
> Tested-by: Ross Brattain <ross.b.brattain@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Jeff, I still think this change is bogus.

PAGE_SIZE is variable, so the chip can't possibly only BUG on that
specific value.

Maybe the condition is "any power-of-2 larger than or equal to 4096"?
Or something like that?

I pointed this out last night, and I was really hoping I'd get actual
feedback on this issue before you're respin your tree.

I'm not pulling in these changes until I get a human being telling me
what the situation is here with this bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html