netdev - Re: [PATCH]netdev: add driver for enc424j600 ethernet chip on SPI bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110130115516.GA8392@electric-eye.fr.zoreil.com>
Date:	Sun, 30 Jan 2011 12:55:16 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Balaji Venkatachalam <balaji.v@...takaa.com>
Cc:	netdev@...r.kernel.org, mirqus@...il.com, mohan@...takaa.com,
	blue.cube@...nam.cz, lanconelli.claudio@...ar.com,
	sriram@...takaa.com, David Miller <davem@...emloft.net>,
	"vbalaji.acs" <vbalaji.acs@...il.com>
Subject: Re: [PATCH]netdev: add driver for enc424j600 ethernet chip on SPI bus

Balaji Venkatachalam <balaji.v@...takaa.com> :
> From: Balaji Venkatachalam <balaji.v@...takaa.com>
> Updated patch [V1.29] for Microchip enc424j600 ethernet chip controlled via SPI.
> 
> I tested it on my custom board with ARM9 (Freescale i.MX233) with
> Kernel 2.6.31.14.
[...]
> 4. mapped enc424j600_dump_regs to eth_ops get_regs

There is some kind of misunderstanding.

See include/linux/ethtool.h
[...]
struct ethtool_ops {
        int     (*get_settings)(struct net_device *, struct ethtool_cmd *);
        int     (*set_settings)(struct net_device *, struct ethtool_cmd *);
        void    (*get_drvinfo)(struct net_device *, struct ethtool_drvinfo *);
        int     (*get_regs_len)(struct net_device *);
        void    (*get_regs)(struct net_device *, struct ethtool_regs *, void *);

It should not even compile.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html