netdev - Re: gro: Reset dev pointer on reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110129.204511.71113208.davem@davemloft.net>
Date:	Sat, 29 Jan 2011 20:45:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org
Subject: Re: gro: Reset dev pointer on reuse

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sun, 30 Jan 2011 15:10:47 +1100

> gro: Reset dev pointer on reuse
> 
> On older kernels the VLAN code may zero skb->dev before dropping
> it and causing it to be reused by GRO.
> 
> Unfortunately we didn't reset skb->dev in that case which causes
> the next GRO user to get a bogus skb->dev pointer.
> 
> This particular problem no longer happens with the current upstream
> kernel due to changes in VLAN processing.
> 
> However, for correctness we should still reset the skb->dev pointer
> in the GRO reuse function in case a future user does the same thing.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks Herbert.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html