netdev - Re: [PATCH v2 16/16] skge: convert to hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110131230833.GA25076@rere.qmqm.pl>
Date:	Tue, 1 Feb 2011 00:08:33 +0100
From:	Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH v2 16/16] skge: convert to hw_features

On Mon, Jan 31, 2011 at 10:53:43PM +0100, Michał Mirosław wrote:
> On Mon, Jan 31, 2011 at 08:45:02AM -0800, Stephen Hemminger wrote:
> > On Sat, 22 Jan 2011 23:14:14 +0100 (CET)
> > Michał Mirosław <mirq-linux@...e.qmqm.pl> wrote:
> > > The hardware might do full HW_CSUM, not just IP_CSUM, but it's not tested
> > > and so not changed here.
> > > Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> > The skge hardware does not do full HW_CSUM. It looks at the IP header.
> Driver code suggests otherwise. Please look at skge_xmit_frame() and TX
> descriptor format.

Ah, I just noticed you wrote most of the code. :-)

Anyway, I still think you're wrong on this. I'll get back to it if I find
the time to create a proper test for other people with similar hardware.
This might be an academic dispute unless we can get at the docs.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html