netdev - Re: [PATCH] isdn: icn: Fix potentially wrong string handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110201.141823.59678888.davem@davemloft.net>
Date:	Tue, 01 Feb 2011 14:18:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	weil@...l.berlios.de
Cc:	isdn@...ux-pingi.de, tj@...nel.org, rostedt@...dmis.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn: icn: Fix potentially wrong string handling

From: Stefan Weil <weil@...l.berlios.de>
Date: Sun, 30 Jan 2011 21:31:26 +0100

> This warning was reported by cppcheck:
> drivers/isdn/icn/icn.c:1641: error: Dangerous usage of 'rev' (strncpy doesn't always 0-terminate it)
> 
> If strncpy copied 20 bytes, the destination string rev was not terminated.
> The patch adds one more byte to rev and makes sure that this byte is
> always 0.
> 
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Stefan Weil <weil@...l.berlios.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html