netdev - Re: [PATCH] IPv6 configurable default value for the privacy extension flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110201135710.0d7c5a54@baileys.at.home>
Date:	Tue, 1 Feb 2011 13:57:10 +0100
From:	Julien Aube <j.aube@...oste.net>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] IPv6 configurable default value for the privacy
 extension flag

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Tue, 01 Feb 2011 13:04:37 +0900,
YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org> a écrit :

> Hello.
> 
> (2011/02/01 0:49), Julien Aube wrote:
> 
> >+	} else {
> >+		printk(KERN_WARNING "IPv6 Privacy Extension "
> >+	"is disabled by default (invalid value %d)\n", ipv6_default_privacy);
> >+	}
> 
> I think WARNING is too high.

I did put KERN_WARNING because this code is used when someone explicitly set 
an invalid value, e.g.
 ipv6.privacy_default=-1

But you're right, I'll set KERN_NOTICE instead.

What do you think of the idea by itself anyhow ?

Thanks for the feedback.

Julien
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1IAyYACgkQHiz1mD2sU8g39QCg6FY8LFCBwyX310cAZYdyVHJA
a4wAoOSDXBZGgayReuZ5wvzE7iZRiHZr
=7i5B
-----END PGP SIGNATURE-----