netdev - Re: [PATCH] vxge: Fix wrong boolean operator {nodisc}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110201.123012.193709953.davem@davemloft.net>
Date:	Tue, 01 Feb 2011 12:30:12 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Ramkrishna.Vepa@...r.com
Cc:	weil@...l.berlios.de, Sivakumar.Subramani@...r.com,
	Sreenivasa.Honnur@...r.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jon.Mason@...r.com
Subject: Re: [PATCH] vxge: Fix wrong boolean operator {nodisc}

From: Ramkrishna Vepa <Ramkrishna.Vepa@...r.com>
Date: Mon, 31 Jan 2011 23:26:40 -0800

>> This error is reported by cppcheck:
>> drivers/net/vxge/vxge-config.c:3693: warning: Mutual exclusion over ||
>> always evaluates to true. Did you intend to use && instead?
>> 
>> It looks like cppcheck is correct, so fix this. No test was run.
>> 
>> Signed-off-by: Stefan Weil <weil@...l.berlios.de>
...
> Fix looks good. Thanks!
> 
> Acked-by: Ram Vepa <ram.vepa@...r.com>

Thanks for reviewing, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html