netdev - Re: [PATCH] sfq: deadlock in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1296697862.4434.1.camel@edumazet-laptop>
Date:	Thu, 03 Feb 2011 02:51:02 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] sfq: deadlock in error path

Le mercredi 02 février 2011 à 17:19 -0800, Stephen Hemminger a écrit :
> The change to allow divisor to be a parameter (in 2.6.38-rc1)
>  commit 817fb15dfd988d8dda916ee04fa506f0c466b9d6
> introduced a possible deadlock caught by sparse.
> 
> The scheduler tree lock was left locked in the case of an incorrect
> divisor value. Simplest fix is to move test outside of lock
> which also solves problem of partial update.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Oops, thanks Stephen !

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

But please, please, please, please, please, remove dada1@...mosbay.com,
as this address is no longer usable for me !



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html