netdev - Re: [net-2.6 PATCH 2/3] net: dcb: use _safe() version of list iterators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D4DA7B3.4030208@intel.com>
Date:	Sat, 05 Feb 2011 11:40:35 -0800
From:	John Fastabend <john.r.fastabend@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-2.6 PATCH 2/3] net: dcb: use _safe() version of list iterators

On 1/31/2011 8:42 PM, David Miller wrote:
> From: John Fastabend <john.r.fastabend@...el.com>
> Date: Mon, 31 Jan 2011 14:00:54 -0800
> 
>> Use _safe() version of list iterator macros in dcb_setapp().
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
> 
> Why?  It's unnecessary overhead, since we always branch to "out", and
> therefore out of the list traversal loop, any time we list_del()
> something on the list.

Of course you are right there is no reason for this. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html