netdev - Re: [PATCH v4 0/5] net: Unified offload configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110207.133721.48496023.davem@davemloft.net>
Date:	Mon, 07 Feb 2011 13:37:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mirq-linux@...e.qmqm.pl
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com
Subject: Re: [PATCH v4 0/5] net: Unified offload configuration

From: Micha┅ Miros┅aw <mirq-linux@...e.qmqm.pl>
Date: Thu,  3 Feb 2011 15:21:21 +0100 (CET)

> Here's a v4 of the ethtool unification patch series.
> 
> What's in it?
>  1:
> 	the patch - implement unified ethtool setting ops
>  2..3:
> 	implement interoperation between old and new ethtool ops
>  4:
> 	include RX checksum in features and plug it into new framework
>  5:
> 	convert loopback device to new framework

After these changes the ethtool output is now inaccurate for
RX checksumming.

Before:

davem@...amba:~$ /usr/sbin/ethtool -k eth0
Offload parameters for eth0:
rx-checksumming: on
tx-checksumming: on
scatter-gather: on
tcp segmentation offload: off
udp fragmentation offload: off
generic segmentation offload: on
large receive offload: off
davem@...amba:~$ 

After:

davem@...amba:~$ /usr/sbin/ethtool -k eth0
Offload parameters for eth0:
rx-checksumming: off
tx-checksumming: on
scatter-gather: on
tcp segmentation offload: off
udp fragmentation offload: off
generic segmentation offload: on
large receive offload: off

If the issue is that you require driver or ethtool utility changes in
order for things to keep working properly, then that is not
acceptable.

I'm reverting all of these changes, resubmit them when you have them
in a state such that no regressions will be introduced.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html