netdev - Re: [PATCH] usb: gadget: nokia: disallow compilation with HIGHMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <201102080939.12122.remi.denis-courmont@nokia.com>
Date:	Tue, 8 Feb 2011 09:39:11 +0200
From:	"Rémi Denis-Courmont" 
	<remi.denis-courmont@...ia.com>
To:	ext-eero.nurkkala@...ia.com
Cc:	linux-usb@...r.kernel.org, dbrownell@...rs.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: nokia: disallow compilation with HIGHMEM

On Tuesday 08 February 2011 09:30:45 ext-eero.nurkkala@...ia.com, you wrote:
> From: Eero Nurkkala <ext-eero.nurkkala@...ia.com>
> 
> With HIGHMEM, g_phonet oopses with the following path:
> pn_rx_complete() -> pskb_pull() -> ... kmap_skb_frag() and
> oops with BUG_ON(in_irq()). Thus, if the gadget is enabled,
> it'd better conflict with the HIGHMEM.
> 
> Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@...ia.com>

Acked-by: Rémi Denis-Courmont <remi.denis-courmont@...ia.com>


In the long run, we should probably kludge the skb code like we did in
cdc-phonet.c.

Or better yet, fix kmap_skb_frag() to be less pessimistic. Thing is, the BUG_ON 
is really bogus here. The way we allocated the skb, the fragment really cannot 
be in HIGHMEM...

-- 
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html