netdev - RE: [net-next-2.6 03/16] e1000e: do not wakeup Tx queue until ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8DD2590731AB5D4C9DBF71A877482A90017BADD014@orsmsx509.amr.corp.intel.com>
Date:	Tue, 8 Feb 2011 12:52:56 -0800
From:	"Allan, Bruce W" <bruce.w.allan@...el.com>
To:	David Miller <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"bphilips@...ell.com" <bphilips@...ell.com>
Subject: RE: [net-next-2.6 03/16] e1000e: do not wakeup Tx queue until ready

>-----Original Message-----
>From: David Miller [mailto:davem@...emloft.net]
>Sent: Tuesday, February 08, 2011 12:21 PM
>To: Kirsher, Jeffrey T
>Cc: Allan, Bruce W; netdev@...r.kernel.org; gospo@...hat.com;
>bphilips@...ell.com
>Subject: Re: [net-next-2.6 03/16] e1000e: do not wakeup Tx queue until ready
>
>You should not control the TX queue based upon link status information.
>That's the job of netif_carrier_{on,off}().
>
>The TX queue state should be set based solely upon that state of the
>TX ring, whether it is full or not.
>
>When the netif carrier is off, the packet scheduler is blocked from
>sending packets to the driver.
>
>If that isn't happening, that's a bug which you need to track down.
>Maybe you're not doing netif_carrier_off() early enough.

That's what I understood, but the driver was still getting packets
scheduled, at least that's what appeared to happen.  I'll dig deeper.

Thanks,
Bruce.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html