netdev - Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rx offload is set by ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110208.230404.189683472.davem@davemloft.net>
Date:	Tue, 08 Feb 2011 23:04:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	toshiharu-linux@....okisemi.com
Cc:	netdev@...r.kernel.org, tomoya-linux@....okisemi.com,
	qi.wang@...el.com, yong.y.wang@...el.com,
	andrew.chih.howe.khor@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pch_gbe: Fix the issue which a driver locks when rx
 offload is set by ethtool

From: David Miller <davem@...emloft.net>
Date: Tue, 08 Feb 2011 22:57:02 -0800 (PST)

> From: "Toshiharu Okada" <toshiharu-linux@....okisemi.com>
> Date: Wed, 9 Feb 2011 11:04:11 +0900
> 
>> From: David Miller <davem@...emloft.net>
>> Date: Tue, 08 Feb 2011 16:40:30 -0800 (PST)
>> 
>>>> @@ -531,12 +533,8 @@ void pch_gbe_reinit_locked(struct pch_gbe_adapter 
>>>> *adapter)
>>>>  {
>>>>  struct net_device *netdev = adapter->netdev;
>>>>
>>>> - rtnl_lock();
>>>> - if (netif_running(netdev)) {
>>>> - pch_gbe_down(adapter);
>>>> - pch_gbe_up(adapter);
>>>> - }
>>>> - rtnl_unlock();
>>>> + pch_gbe_down(adapter);
>>>> + pch_gbe_up(adapter);
>>>
>>>Are you sure you can just blindly delete the netif_running() check here?
>> 
>> Yes, sure.
>> pch_gbe_reinit_locked() is called after confirming of netif_running() except 
>> for pch_gbe_reset_task() function.
>> This netif_running() was redundant.
> 
> Thanks for explaining, applied, thank you.

Actually, I had to revert, this patch introduces an obvious compiler warning:

drivers/net/pch_gbe/pch_gbe_main.c: In function 'pch_gbe_reinit_locked':
drivers/net/pch_gbe/pch_gbe_main.c:533:21: warning: unused variable 'netdev'

Sloppy build issues like this reflects very poorly upon the patch
submitter.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html