lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Feb 2011 09:37:41 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: David Miller <davem@...emloft.net> Cc: linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org, aranym@...ts.bobek.cz, schmitz@...l.biophys.uni-duesseldorf.de, pstehlik@...hics.cz, milan.jurik@...ab.cz, netdev@...r.kernel.org Subject: Re: [PATCH 4/4] m68k/atari: ARAnyM - Add support for network access On Sun, Feb 6, 2011 at 20:17, David Miller <davem@...emloft.net> wrote: > From: Geert Uytterhoeven <geert@...ux-m68k.org> > Date: Sun, 6 Feb 2011 11:51:09 +0100 > >> + dev->trans_start = jiffies; > > Device drivers no longer make this operation, the generic code > does it (see net/core/dev.c:dev_hard_start_xmit() and how it > invokes txq_trans_update() on ->ndo_start_xmit() success). > > Therefore, please remove this line. Will do. (180 more to go in drivers/net/?) >> + pr_debug(DRV_NAME ": send %d bytes\n", len); > > For consistency with other network drivers, add an appropriate CPP > define for "pr_fmt" and use netdev_info(), netdev_debug(), etc. > > In situations where a netdev pointer is not available > (ie. pre-register_netdev()), use "dev_*()" instead. Will fix. Thanks for reviewing! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists