netdev - Re: [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1297464081.3544.72.camel@jtkirshe-MOBL1>
Date:	Fri, 11 Feb 2011 14:41:21 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Andy Gospodarek <andy@...yhouse.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Skidmore, Donald C" <donald.c.skidmore@...el.com>,
	"Duyck, Alexander H" <alexander.h.duyck@...el.com>,
	"Rose, Gregory V" <gregory.v.rose@...el.com>
Subject: Re: [PATCH net-2.6] ixgbe: fix panic due to uninitialied pointer

On Fri, 2011-02-11 at 13:45 -0800, Andy Gospodarek wrote:
> Systems containing an 82599EB and running a backported driver from
> upstream were panicing on boot.  It turns out hw->mac.ops.setup_sfp is
> only set for 82599, so one should check to be sure that pointer is set
> before continuing in ixgbe_sfp_config_module_task.  I verified by
> inspection that the upstream driver has the same issue and also added
> a
> check before the call in ixgbe_sfp_link_config.
> 
> Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
> ---
>  drivers/net/ixgbe/ixgbe_main.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-) 

Thanks Andy!  Have added the patch (with fixed subject) to my ixgbe
queue of patches.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)