netdev - Re: bridge: Fix mglist corruption that leads to memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110211.215804.15260765.davem@davemloft.net>
Date:	Fri, 11 Feb 2011 21:58:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	netdev@...r.kernel.org, ihands@...hat.com, jbacik@...hat.com
Subject: Re: bridge: Fix mglist corruption that leads to memory corruption

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sat, 12 Feb 2011 09:55:59 +1100

> On Sat, Feb 12, 2011 at 09:36:55AM +1100, Herbert Xu wrote:
>> 
>> Normally this would be quite obvious as it would cause an infinite
>> loop when walking the list.  However, as this list is never actually
>> walked (which means that we don't really need it, I'll get rid of
>> it in a subsequent patch), this instead is hidden until we perform
>> a delete operation on the affected nodes.
> 
> Here is the patch that replaces the mglist hlist with just a bool.
> 
> bridge: Replace mp->mglist hlist with a bool
> 
> As it turns out we never need to walk through the list of multicast
> groups subscribed by the bridge interface itself (the only time we'd
> want to do that is when we shut down the bridge, in which case we
> simply walk through all multicast groups), we don't really need to
> keep an hlist for mp->mglist.
> 
> This means that we can replace it with just a single bit to indicate
> whether the bridge interface is subscribed to a group.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Well if it's a bool, please use "true" and "false" instead of "1" and
"0" :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html