netdev - Re: [patch net-next-2.6 1/4] rtnetlink: implement setting of master device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D583467.6020803@trash.net>
Date:	Sun, 13 Feb 2011 20:43:35 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Jiri Pirko <jpirko@...hat.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, fubar@...ibm.com,
	eric.dumazet@...il.com, nicolas.2p.debian@...il.com
Subject: Re: [patch net-next-2.6 1/4] rtnetlink: implement setting of master
 device

Am 13.02.2011 20:31, schrieb Jiri Pirko:
> This patch allows userspace to enslave/release slave devices via netlink
> interface using IFLA_MASTER. This introduces generic way to add/remove
> underling devices.

Looks good to me, just one question:

> @@ -1301,6 +1337,12 @@ static int do_setlink(struct net_device *dev, struct ifinfomsg *ifm,
>  			goto errout;
>  	}
>  
> +	if (tb[IFLA_MASTER]) {
> +		err = do_set_master(dev, nla_get_u32(tb[IFLA_MASTER]));
> +		if (err)
> +			goto errout;
> +	}

Any reason why you're not setting "modified" here?

> +
>  	if (tb[IFLA_TXQLEN])
>  		dev->tx_queue_len = nla_get_u32(tb[IFLA_TXQLEN]);
>  

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html