netdev - Re: [PATCH v2] core: dev: don't call BUG() on bad input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110214.112521.104056910.davem@davemloft.net>
Date:	Mon, 14 Feb 2011 11:25:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	segoon@...nwall.com
Cc:	adobriyan@...il.com, linux-kernel@...r.kernel.org,
	eric.dumazet@...il.com, therbert@...gle.com, xiaosuo@...il.com,
	jesse@...ira.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] core: dev: don't call BUG() on bad input

From: Vasiliy Kulikov <segoon@...nwall.com>
Date: Mon, 14 Feb 2011 18:23:10 +0300

> On Mon, Feb 14, 2011 at 17:16 +0200, Alexey Dobriyan wrote:
>> Netdevice name isn't some random junk you get from userspace, so BUG is fine.
> 
> It IS for bluetooth, see net/bluetooth/bnep/core.c: bnep_add_connection() and
> net/bluetooth/bnep/sock.c: bnep_sock_ioctl(). 

If bluetooth wants to allow something so foolish, then it's bluetooth's
responsibility to sanity check the arguments before blinding passing
them into kernel APIs which expect sane inputs.

I'm not applying this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html