netdev - Re: [PATCH] ATM, Solos PCI ADSL2+: Don't deref NULL pointer if net_ratelimit() and alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110213.165554.173868884.davem@davemloft.net>
Date:	Sun, 13 Feb 2011 16:55:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jj@...osbits.net
Cc:	linux-kernel@...r.kernel.org, chas@....nrl.navy.mil,
	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
	nathan@...verse.com.au, dwmw2@...radead.org, treker@...o.com
Subject: Re: [PATCH] ATM, Solos PCI ADSL2+: Don't deref NULL pointer if
 net_ratelimit() and alloc_skb() interact badly.

From: Jesper Juhl <jj@...osbits.net>
Date: Sun, 13 Feb 2011 21:49:32 +0100 (CET)

> If alloc_skb() fails to allocate memory and returns NULL then we want to 
> return -ENOMEM from drivers/atm/solos-pci.c::popen() regardless of the 
> value of net_ratelimit(). The way the code is today, we may not return if 
> net_ratelimit() returns 0, then we'll proceed to pass a NULL pointer to 
> skb_put() which will blow up in our face.
> This patch ensures that we always return -ENOMEM on alloc_skb() failure 
> and only let the dev_warn() be controlled by the value of net_ratelimit().
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html