netdev - Re: [PATCH] tcp: fix inet_twsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110219.185946.193690650.davem@davemloft.net>
Date:	Sat, 19 Feb 2011 18:59:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ebiederm@...ssion.com, acme@...hat.com,
	torvalds@...ux-foundation.org, mhocko@...e.cz, mingo@...e.hu,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, xemul@...nvz.org, daniel.lezcano@...e.fr
Subject: Re: [PATCH] tcp: fix inet_twsk_deschedule()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sat, 19 Feb 2011 09:35:56 +0100

> [PATCH] tcp: fix inet_twsk_deschedule()
> 
> Eric W. Biederman reported a lockdep splat in inet_twsk_deschedule()
> 
> This is caused by inet_twsk_purge(), run from process context,
> and commit 575f4cd5a5b6394577 (net: Use rcu lookups in inet_twsk_purge.)
> removed the BH disabling that was necessary.
> 
> Add the BH disabling but fine grained, right before calling
> inet_twsk_deschedule(), instead of whole function.
> 
> With help from Linus Torvalds and Eric W. Biederman
> 
> Reported-by: Eric W. Biederman <ebiederm@...ssion.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> CC: Daniel Lezcano <daniel.lezcano@...e.fr>
> CC: Pavel Emelyanov <xemul@...nvz.org>
> CC: Arnaldo Carvalho de Melo <acme@...hat.com>
> CC: stable <stable@...nel.org> (# 2.6.33+)

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html